Skip to content

TST: re-enable gbq tests #23303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2018
Merged

TST: re-enable gbq tests #23303

merged 1 commit into from
Oct 26, 2018

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Oct 23, 2018 •
edited
Loading

Fix clean-up steps to use the google.cloud.bigquery client
library directly, since some of the _Dataset and _Table
logic was removed from pandas-gbq.

Follow-up to #23281

  • tests added / passed
$ pytest pandas/tests/io/test_gbq.py
====== test session starts ======
platform darwin -- Python 3.6.4, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/Users/swast/src/pandas/pandas/.hypothesis/examples')
rootdir: /Users/swast/src/pandas/pandas, inifile: setup.cfg
plugins: xdist-1.22.2, forked-0.2, cov-2.5.1, hypothesis-3.70.3
collected 2 items

pandas/tests/io/test_gbq.py ..           [100%]

====== slowest 10 test durations ======
12.55s call     pandas/tests/io/test_gbq.py::TestToGBQIntegrationWithServiceAccountKeyPath::test_roundtrip
1.30s setup    pandas/tests/io/test_gbq.py::TestToGBQIntegrationWithServiceAccountKeyPath::test_roundtrip
0.66s teardown pandas/tests/io/test_gbq.py::TestToGBQIntegrationWithServiceAccountKeyPath::test_roundtrip
0.18s call     pandas/tests/io/test_gbq.py::test_read_gbq_without_dialect_warns_future_change
0.00s setup    pandas/tests/io/test_gbq.py::test_read_gbq_without_dialect_warns_future_change
0.00s teardown pandas/tests/io/test_gbq.py::test_read_gbq_without_dialect_warns_future_change
====== 2 passed in 15.00 seconds ======
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@tswast
TST: re-enable gbq tests
4115ef2 
Fix clean-up steps to use the google.cloud.bigquery client
library directly, since some of the _Dataset and _Table
logic was removed from pandas-gbq.
@pep8speaks
Copy link

Hello @tswast! Thanks for submitting the PR.

@tswast tswast mentioned this pull request Oct 23, 2018
Merged
@codecov
Copy link

codecov bot commented Oct 24, 2018 •
edited
Loading

Codecov Report

Merging #23303 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23303   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         169      169           
  Lines       50897    50897           
=======================================
  Hits        46940    46940           
  Misses       3957     3957
Flag Coverage Δ
#multiple 90.65% <ø> (ø) ⬆️
#single 42.29% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0c91e...4115ef2. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Oct 24, 2018

is the min version for pandas-gbq good in the install?

@jreback jreback added this to the 0.24.0 milestone Oct 24, 2018
@tswast
Copy link
Contributor Author

tswast commented Oct 24, 2018 •
edited
Loading

I think the min version should be 0.6.0. Should I set that in the importorskip? I don't see versions for pandas-gbq anywhere when I search for it.

The last time we changed the arguments to read_gbq was googleapis/python-bigquery-pandas#196, which shipped in 0.6.0 / 2018-08-15 and I updated pandas in #22557 for that change.

@jreback
Copy link
Contributor

jreback commented Oct 26, 2018

this is fine, we are only testing on a single build I think. We should move this to the 3.6 build. If you want to update the min version its ok by me (or not is fine too), I think mostly people just install the latest.

@jreback jreback merged commit d3a7df1 into pandas-dev:master Oct 26, 2018
@jreback
Copy link
Contributor

jreback commented Oct 26, 2018

thanks @tswast

@tswast tswast deleted the pr23281-gbq-tests branch October 26, 2018 00:34
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@tswast @tm9k1
TST: re-enable gbq tests (pandas-dev#23303)
5632cca 
Fix clean-up steps to use the google.cloud.bigquery client
library directly, since some of the _Dataset and _Table
logic was removed from pandas-gbq.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@tswast @Pingviinituutti
TST: re-enable gbq tests (pandas-dev#23303)
21bbfcb 
Fix clean-up steps to use the google.cloud.bigquery client
library directly, since some of the _Dataset and _Table
logic was removed from pandas-gbq.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@tswast @Pingviinituutti
TST: re-enable gbq tests (pandas-dev#23303)
322850f 
Fix clean-up steps to use the google.cloud.bigquery client
library directly, since some of the _Dataset and _Table
logic was removed from pandas-gbq.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @pep8speaks @jreback